Arm backend: Use correct log-level in tests #15545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15545
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 7 Unrelated FailuresAs of commit 01e52a4 with merge base 357d573 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
oscarandersson8218
force-pushed
the
reduce_arm_tester_logs
branch
from
3c424f8 to
dd7c559
Compare
zingo
reviewed
Nov 5, 2025
Arm tests logged too much as comparisons with logger.level were used instead of logger.getEffectiveLevel(). logger.level will always be logging.NOTSET unless explicitly set with logger.setLevel() which we want to avoid. Instead, we should use logger.getEffectiveLevel() which will inherit the level from its parent. Signed-off-by: Oscar Andersson <[email protected]> Change-Id: If863593e7dbe455999d5b7bca33cc2511aa3ee50
dump_operator_distribution now prints instead of log to align behavior with dump_artifact. Also fixes a log-level comparison in ethosu_backend. Signed-off-by: Oscar Andersson <[email protected]> Change-Id: I53eb8dcb1197e420abdb8a635fe2eaad925acaae
Signed-off-by: Oscar Andersson <[email protected]> Change-Id: Ifb6b797575de9a4d360b6f4c740ebfa9836fe495
oscarandersson8218
force-pushed
the
reduce_arm_tester_logs
branch
from
dd7c559 to
01e52a4
Compare
zingo
approved these changes
Nov 6, 2025
Collaborator
|
Fails unrelated, buck2 files should not be needed to be adopted |
abhinaykukkadapu
pushed a commit
to abhinaykukkadapu/executorch
that referenced
this pull request
Nov 6, 2025
Arm tests logged too much as comparisons with logger.level were used instead of logger.getEffectiveLevel(). logger.level will always be logging.NOTSET unless explicitly set with logger.setLevel() which we want to avoid. Instead, we should use logger.getEffectiveLevel() which will inherit the level from its parent. Signed-off-by: Oscar Andersson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arm tests logged too much as comparisons with logger.level were used instead of logger.getEffectiveLevel(). logger.level will always be logging.NOTSET unless explicitly set with logger.setLevel() which we want to avoid. Instead, we should use logger.getEffectiveLevel() which will inherit the level from its parent.
cc @freddan80 @per @zingo @digantdesai